netdev - Re: [PATCH net-next] tcp: switch rtt estimations to usec resolution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1402232102370.1460@ja.home.ssi.bg>
Date:	Sun, 23 Feb 2014 21:11:13 +0200 (EET)
From:	Julian Anastasov <ja@....bg>
To:	Eric Dumazet <eric.dumazet@...il.com>
cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Yuchung Cheng <ycheng@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Larry Brakmo <brakmo@...gle.com>
Subject: Re: [PATCH net-next] tcp: switch rtt estimations to usec
 resolution


	Hello,

On Sun, 23 Feb 2014, Eric Dumazet wrote:

> > 	What is the way to handle this change of
> > resolution in TCP_METRICS_ATTR_VALS? The ip tool has
> > code in ip/tcp_metrics.c process_msg() that needs to
> > know what we get, ms or us. Do we need to add some
> > new attribute as flag or version? Or we need to increase
> > TCP_METRICS_GENL_VERSION in kernel and to check it in
> > process_msg ?
> 
> crap... This should have been usec units as we did for tcp_info years
> ago.
> 
> Solution is to add TCP_METRIC_RTT_US and TCP_METRIC_RTTVAR_US attributes
> 
> I'll send a v2

	What about ip/iproute.c, according to tcpm_suck_dst
print_route and iproute_modify use the same ms-based units.

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html