netdev - kernel driver "drivers/net/ethernet/realtek/r8169.c" msleep question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140223223840.GA29808@snape.qqa.nl>
Date:	Sun, 23 Feb 2014 23:38:40 +0100
From:	Justin van Wijngaarden <justinvanwijngaarden@...il.com>
To:	nic_swsd@...ltek.com
Cc:	netdev@...r.kernel.org, romieu@...zoreil.com
Subject: kernel driver "drivers/net/ethernet/realtek/r8169.c" msleep question

Hello,

I am in the progress of doing some checkpatch.pl clean-ups and took the above
driver to work on.

On line 6926 there is an msleep(1) statement.

According to the linux documentation @ Documentation/timers/timers-howto.txt
the msleep is not functioning as it should.

see output from that documentation below.

// quote
Why not msleep for (1ms - 20ms)?
	Explained originally here:
	http://lkml.org/lkml/2007/8/3/250
	msleep(1~20) may not do what the caller intends, and
	will often sleep longer (~20 ms actual sleep for any
	value given in the 1~20ms range).  In many cases this
	is not the desired behavior.
// end quote

If you like I can take a re-write to usleep (1ms) or perhaps a 10/20 msleep.
I tested it both with my own hardware which works fine on both cases, but
ofcourse I don't have the hardware to test it for all use-cases.

Any preference?

Regards,

Justin van Wijngaarden
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html