netdev - Re: [PATCH v4 net-next] tcp: switch rtt estimations to usec resolution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1393280364.2316.79.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 24 Feb 2014 14:19:24 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Yuchung Cheng <ycheng@...gle.com>, netdev <netdev@...r.kernel.org>,
	Neal Cardwell <ncardwell@...gle.com>,
	Larry Brakmo <brakmo@...gle.com>, Julian Anastasov <ja@....bg>
Subject: Re: [PATCH v4 net-next] tcp: switch rtt estimations to usec
 resolution

On Mon, 2014-02-24 at 10:24 -0800, Eric Dumazet wrote:


> index d547075d8300..8e4c43d80784 100644
> --- a/net/ipv4/tcp_metrics.c
> +++ b/net/ipv4/tcp_metrics.c

...

> -	if (crtt > tp->srtt) {
> +	if (crtt > tp->srtt_us) {
>  		/* Set RTO like tcp_rtt_estimator(), but from cached RTT. */
>  		crtt >>= 3;
> -		inet_csk(sk)->icsk_rto = crtt + max(2 * crtt, tcp_rto_min(sk));
> -	} else if (tp->srtt == 0) {

This part is buggy it needs to be :

	crtt /= 8 * USEC_PER_MSEC;
	inet_csk(sk)->icsk_rto = crtt + max(2 * crtt, tcp_rto_min(sk));


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html