netdev - Re: [PATCH net-next 4/4] bonding: don't ensalve loopback device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140224.182808.25115590214594070.davem@davemloft.net>
Date:	Mon, 24 Feb 2014 18:28:08 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	fubar@...ibm.com, vfalico@...hat.com, andy@...yhouse.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 4/4] bonding: don't ensalve loopback device

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Fri, 21 Feb 2014 16:08:55 +0800

> I could not see any effect that enslave a loopback device, so don't
> enslave such device for bonding.
> 
> Use pr_err to instead of pr_debug when return error.
> 
> Cc: Jay Vosburgh <fubar@...ibm.com>
> Cc: Veaceslav Falico <vfalico@...hat.com>
> Cc: Andy Gospodarek <andy@...yhouse.net>
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>

I do not agree at all with this patch, you can't just stop providing
functionality because you personally can't figure out a way in which
to use it.

I'll apply the other 3 patches, those are fine.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html