netdev - Re: [PATCH] net: stmmac: Check return value of alloc_dma_desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Feb 2014 16:22:08 +0100
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Tobias Klauser <tklauser@...tanz.ch>
Cc:	<netdev@...r.kernel.org>
Subject: Re: [PATCH] net: stmmac: Check return value of alloc_dma_desc_resources()

On 2/22/2014 1:09 PM, Tobias Klauser wrote:
> alloc_dma_desc_resources() returns an error value and the next line
> actually checks for it, so assign the return value properly.
>
> Found by the coverity scanner.
>
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

> ---
>   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index a2e7d2c..078ad0e 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -1705,7 +1705,7 @@ static int stmmac_open(struct net_device *dev)
>   	priv->dma_rx_size = STMMAC_ALIGN(dma_rxsize);
>   	priv->dma_buf_sz = STMMAC_ALIGN(buf_sz);
>
> -	alloc_dma_desc_resources(priv);
> +	ret = alloc_dma_desc_resources(priv);
>   	if (ret < 0) {
>   		pr_err("%s: DMA descriptors allocation failed\n", __func__);
>   		goto dma_desc_error;
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html