netdev - RE: [PATCH net-next 0/3] bnx2x: minimize RAM usage in kdump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6AE768456CEC4B4A9B2248CB6B87EB3E1C01B891@SJEXCHMB05.corp.ad.broadcom.com>
Date:	Tue, 25 Feb 2014 16:41:07 +0000
From:	Ariel Elior <ariele@...adcom.com>
To:	Michal Schmidt <mschmidt@...hat.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Dmitry Kravkov <dmitry@...adcom.com>,
	Yuval Mintz <yuvalmin@...adcom.com>
Subject: RE: [PATCH net-next 0/3] bnx2x: minimize RAM usage in kdump

> -----Original Message-----
> From: Michal Schmidt [mailto:mschmidt@...hat.com]
> Sent: Tuesday, February 25, 2014 5:04 PM
> To: davem@...emloft.net
> Cc: netdev@...r.kernel.org; Ariel Elior; Dmitry Kravkov; Yuval Mintz
> Subject: [PATCH net-next 0/3] bnx2x: minimize RAM usage in kdump
> 
> kdump kernels usually have only a small amount of memory reserved.
> bnx2x can be memory-hungry. Let's minimize its memory usage when
> running in kdump.
> 
> I detect kdump by looking at the "reset_devices" flag. A couple of
> storage drivers (cciss, hpsa) use it for the same purpose. I am not sure
> this is the best way to solve the problem, but it works.
> 
> Should it be made more generic by, say, looking at the total amount
> of lowmem instead? Not using TPA by default when lowmem is small and/or
> defaulting to fewer queues would help 32bit systems where a driver for
> a multi-function multi-queue NIC can consume a significant amount
> of available memory. Or do we want no such heuristics?
> 
> Is this something to consider doing for other network drivers too?
> 
> Michal Schmidt (3):
>   bnx2x: clamp num_queues to prevent passing a negative value
>   bnx2x: save RAM in kdump kernel by using a single queue
>   bnx2x: save RAM in kdump kernel by disabling TPA
> 
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c  | 12 ++++++++----
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |  2 ++
>  2 files changed, 10 insertions(+), 4 deletions(-)
> 
> --
> 1.8.5.3

This series looks good, in the sense that it modifies the driver in a correct way to achieve the intended result (less memory on kdump).
The basic question of testing lowmem vs. reset_devices or perhaps some other parameter still needs to be answered though.
Acked-by: Ariel Elior <ariele@...adcom.com>

Thanks,
Ariel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html