netdev - Re: [PATCH v6 net-next 2/2] tcp: switch rtt estimations to usec resolution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQymGQ6V_28MTu02Yo7XjQz5OvmkbW3ozUvovhoz8g0rp=w@mail.gmail.com>
Date:	Tue, 25 Feb 2014 12:46:40 -0500
From:	Neal Cardwell <ncardwell@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	Julian Anastasov <ja@....bg>,
	David Miller <davem@...emloft.net>,
	Yuchung Cheng <ycheng@...gle.com>,
	netdev <netdev@...r.kernel.org>, Larry Brakmo <brakmo@...gle.com>
Subject: Re: [PATCH v6 net-next 2/2] tcp: switch rtt estimations to usec resolution

On Tue, Feb 25, 2014 at 1:22 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> Upcoming congestion controls for TCP require usec resolution for RTT
> estimations. Millisecond resolution is simply not enough these days.
...
> ---
> v6: Do not use ktime_get() but skb_mstamp, as Stephen Hemminger pointed
>     out some platforms have slow ktime_get()
...
>
> -                       ca_ops->pkts_acked(sk, pkts_acked, rtt_us);
> -               }
> -       } else if (skb && rtt_update && sack_rtt >= 0 &&
> -                  sack_rtt > (s32)(now - TCP_SKB_CB(skb)->when)) {
> +       } else if (skb && rtt_update && sack_rtt_us >= 0 &&
> +                  sack_rtt_us > skb_mstamp_us_delta(&now, &skb->skb_mstamp)) {

This gets rid of the (s32) cast for the result of the time
subtraction. Is that safe?

The rest looks great to me!

neal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html