netdev - Re: [PATCH net-next] ipv6: log src and dst along with "udp checksum is 0"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Feb 2014 21:07:12 +0100
From:	Bjørn Mork <bjorn@...k.no>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipv6: log src and dst along with "udp checksum is 0"

Joe Perches <joe@...ches.com> writes:

> On Tue, 2014-02-25 at 20:34 +0100, Bjørn Mork wrote:
>> These info messages are rather pointless without any means to identify
>> the source of the bogus packets.  Logging the src and dst addresses
>> may help a bit.
> []
>> diff --git a/net/ipv6/ip6_checksum.c b/net/ipv6/ip6_checksum.c
> []
>> @@ -79,7 +79,8 @@ int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh, int proto)
>>  		/* RFC 2460 section 8.1 says that we SHOULD log
>>  		   this error. Well, it is reasonable.
>>  		 */
>> -		LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0\n");
>> +		LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0 [%pI6c > %pI6c]\n",
>> +			       &ipv6_hdr(skb)->saddr, &ipv6_hdr(skb)->daddr);
>
> Might be useful to mirror the ipv4 form and add port #'s too.

Good point. New version coming up.



Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html