netdev - bcmgenet's custom ->ndo_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140224.193229.2076944569180242866.davem@davemloft.net>
Date:	Mon, 24 Feb 2014 19:32:29 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
CC:	netdev@...r.kernel.org
Subject: bcmgenet's custom ->ndo_select_queue()

While fixing a build warning:

drivers/net/ethernet/broadcom/genet/bcmgenet.c:2293:2: warning: initialization from incompatible pointer type [enabled by default]

I see that bcmgenet's implementation is:

	return netif_is_multiqueue(dev) ? skb->queue_mapping : 0;

That makes no sense at all.

You should only define an overriding function here if you want to do
something uniqueue, and not use the default.

If you don't assign the queue mapping, it's not even going to be
set when your select_queue method is called.  In _FACT_ that's the
reason it is called, to get the queue mapping set.

I'm just deleting this completely, I hope you don't mind.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html