netdev - RE: [RFC 3/3] bnx2x: Use pci_set_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <979A8436335E3744ADCD3A9F2A2B68A52AF6EE08@SJEXCHMB10.corp.ad.broadcom.com>
Date:	Tue, 25 Feb 2014 11:21:13 +0000
From:	Yuval Mintz <yuvalmin@...adcom.com>
To:	Jon Mason <jdmason@...zu.us>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	Ariel Elior <ariele@...adcom.com>
Subject: RE: [RFC 3/3] bnx2x: Use pci_set_power_state() for setting PM states

> Use the existing infrastructure of pci_set_power_state() instead of
> setting the relevant bits via PCI config read/write in the driver.
> Also, use the d3_delay field to specify how long to msleep after putting
> the device in the appropriate power management state.  Finally, use
> pci_pme_active() to set the PCI_PM_CTRL_PME_ENABLE bit in PCI PM control
> register.  pci_set_power_state() and pci_pme_active() perform the same
> operations as the driver did before, so there should be no functional
> change.  That being said, this has not been tested.
> 
> Signed-off-by: Jon Mason <jdmason@...zu.us>
> Cc: Ariel Elior <ariele@...adcom.com>

Acked-by: Yuval Mintz <yuvalmin@...adcom.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html