netdev - Re: [PATCH] net: kdoc struct net_device flags and priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1393336029.6823.161.camel@deadeye.wl.decadent.org.uk>
Date:	Tue, 25 Feb 2014 13:47:09 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	mcgrof@...not-panic.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, mcgrof@...e.com
Subject: Re: [PATCH] net: kdoc struct net_device flags and priv_flags

On Mon, 2014-02-24 at 23:53 -0500, David Miller wrote:
> From: Ben Hutchings <ben@...adent.org.uk>
> Date: Tue, 25 Feb 2014 02:11:05 +0000
> 
> > On Mon, 2014-02-24 at 16:14 -0800, Luis R. Rodriguez wrote:
> >> From: "Luis R. Rodriguez" <mcgrof@...e.com>
> >> 
> >> ---
> >>  include/uapi/linux/if.h | 201 +++++++++++++++++++++++++++++++++++-------------
> >>  1 file changed, 149 insertions(+), 52 deletions(-)
> >> 
> >> diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h
> >> index d758163..1555623 100644
> >> --- a/include/uapi/linux/if.h
> >> +++ b/include/uapi/linux/if.h
> > [...]
> >> +/**
> >> + * enum net_device_priv_flags - &struct net_device priv_flags
> >> + *
> >> + * These are the &struct net_device, they are only set internally
> >> + * by drivers and used in the kernel but are invisible to userspace.
> > [...]
> > 
> > Indeed, I wonder why they are in the UAPI header.  As userland doesn't
> > have a legitimate use for them, maybe you could move them back to
> > include/linux/if.h instead of bothering with adding macros?
> 
> They are visible to userspace via sysfs.

Really, I don't see them.  Also they were renumbered a while ago (commit
080e4130b1fb) so they're not a stable interface.

> My memory may be bad, but I believe this has been brought up before.

I expect it has, yes.

Ben.

-- 
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
                                                           - Albert Einstein

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)