netdev - [PATCH] sh_net: runtime pm wrap mdio read and write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Feb 2014 16:48:39 +0000
From:	Ben Dooks <ben.dooks@...ethink.co.uk>
To:	netdev@...r.kernel.org
Cc:	linux-sh@...r.kernel.org, sergei.shtylyov@...entembedded.com,
	nobuhiro.iwamatsu.yj@...esas.com, magnus.damn@...nsource.se,
	horms@...ge.net.au, Ben Dooks <ben.dooks@...ethink.co.uk>
Subject: [PATCH] sh_net: runtime pm wrap mdio read and write

On the R8A7790, if the device has been suspended by pm_runtime
and the MII code tries to access the bus then there is a possiblity
that it will fail to read any data from the MII bus.

Change the MDIO read and write calls to be wrappered by calls to
pm_runtime_{get,put}_sync so that the device will be enabled during
these calls. It is put here to avoid having to enable and disable
the clock for every bit that is sent by the MII bit-banging code.

This has been exposed by the change to using OF and a fix to enable
the pm_runtime clock management which seems to have been broken for
some time for the device-tree booted Renesas kernels.

Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
---
 drivers/net/ethernet/renesas/sh_eth.c | 39 +++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index b92034c..8d1b84e 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -983,6 +983,8 @@ static unsigned long sh_eth_get_edtrr_trns(struct sh_eth_private *mdp)
 
 struct bb_info {
 	void (*set_gate)(void *addr);
+        int (*mdio_read)(struct mii_bus *bus, int phy_id, int regnum);
+        int (*mdio_write)(struct mii_bus *bus, int phy_id, int regnum, u16 val);
 	struct mdiobb_ctrl ctrl;
 	void *addr;
 	u32 mmd_msk;/* MMD */
@@ -1071,6 +1073,38 @@ static struct mdiobb_ops bb_ops = {
 	.get_mdio_data = sh_get_mdio,
 };
 
+/* Wrapper to ensure bitbang ops have device runtime-pm enabled */
+
+static inline struct bb_info *mii_to_bitbang(struct mii_bus *bus)
+{
+	struct mdiobb_ctrl *ctrl = bus->priv;
+	return container_of(ctrl, struct bb_info, ctrl);
+}
+
+static int sh_mdio_read(struct mii_bus *bus, int phy_id, int regnum)
+{
+	struct bb_info *bitbang = mii_to_bitbang(bus);
+	int ret;
+
+	pm_runtime_get_sync(bus->dev.parent->parent);
+	ret = bitbang->mdio_read(bus, phy_id, regnum);
+	pm_runtime_put_sync(bus->dev.parent->parent);
+
+	return ret;
+}
+
+static int sh_mdio_write(struct mii_bus *bus, int phy_id, int regnum, u16 val)
+{
+	struct bb_info *bitbang = mii_to_bitbang(bus);
+	int ret;
+
+	pm_runtime_get_sync(bus->dev.parent->parent);
+	ret = bitbang->mdio_write(bus, phy_id, regnum, val);
+	pm_runtime_put_sync(bus->dev.parent->parent);
+
+	return ret;
+}
+
 /* free skb and descriptor buffer */
 static void sh_eth_ring_free(struct net_device *ndev)
 {
@@ -2639,6 +2673,11 @@ static int sh_mdio_init(struct net_device *ndev, int id,
 		goto out;
 	}
 
+	bitbang->mdio_read = mdp->mii_bus->read;
+	bitbang->mdio_write = mdp->mii_bus->write;
+	mdp->mii_bus->read = sh_mdio_read;
+	mdp->mii_bus->write = sh_mdio_write;
+
 	/* Hook up MII support for ethtool */
 	mdp->mii_bus->name = "sh_mii";
 	mdp->mii_bus->parent = &ndev->dev;
-- 
1.8.5.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html