netdev - Re: RTL8153 fails to get link after applying c7de7dec2 to 3.8 kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANEJEGtJfUsond3kowuQ24JbLdE71CGEtX4BgMDKyG2AFuiniw@mail.gmail.com>
Date:	Wed, 26 Feb 2014 09:19:29 -0800
From:	Grant Grundler <grundler@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	Hayes Wang <hayeswang@...ltek.com>,
	Inki Yoo <inky.yoo@...sung.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: RTL8153 fails to get link after applying c7de7dec2 to 3.8 kernel

On Wed, Feb 26, 2014 at 8:58 AM, David Miller <davem@...emloft.net> wrote:
> From: hayeswang <hayeswang@...ltek.com>
> Date: Wed, 26 Feb 2014 18:13:00 +0800
>
>> Grant Grundler [mailto:grundler@...gle.com]
>>> Sent: Tuesday, February 25, 2014 12:18 AM
>>> To: hayeswang
>>> Cc: Inki Yoo; netdev
>>> Subject: Re: RTL8153 fails to get link after applying
>>> c7de7dec2 to 3.8 kernel
>> [...]
>>> Does Realtek have a publicly available tool that I can use to set all
>>> customization back to "official" values?
>>
>> Please contact with the person who give you the dangle.
>> You should need the another one.
>
> This is not an appropriate response.
>
> Your company made a chip, and people are going to repackage it and
> reuse it in their own implementations.
>
> Sometimes they will set jumpers incorrectly, add bugs to the firmware,
> and make other mistakes.
>
> When you are made explicitly awre of such situations, your driver
> should absolutely strive to handle that, rather than refuse to.

Dave,
I agree with this - but it's possible Samsung sent me prototype
devices that are not "final HW" and I sympathize with Hayes that these
handful of devices should be replaced/recycled.  Since these have
"RealTek" logo on them, I expect the HW to be final and something is
b0rked in this device's firmware.

I'll report back once I get this sorted out. I've made it clear to
contacts at both Samsung and Realtek the upstream driver needs to work
and they need to sort out why the devices I have now don't "just
work".

> It is mysterious to me when a driver author behaves in such a way that
> they seem to want their driver to work on fewer instances of their
> hardware rather than support more of them.

Well, we don't know the whole story. Samsung asked for a different USB
Vendor/Device ID and it's possible a few other things got change along
the way.

If this HW/FW was clearly production and I had a patch that made it
work, then we'd be in the situation you are describing.

thanks,
grant
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html