netdev - Re: [RESEND] [PATCH v4] sh_eth: update OF PHY registeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcYHF_5Ovz2AnNshQ508OqKjiX5Yf0H4ZfXjayWCtQmN8w@mail.gmail.com>
Date:	Wed, 26 Feb 2014 11:05:00 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Ben Dooks <ben.dooks@...ethink.co.uk>,
	netdev <netdev@...r.kernel.org>,
	Linux-sh list <linux-sh@...r.kernel.org>,
	nobuhiro.iwamatsu.yj@...esas.com, magnus.damn@...nsource.se,
	Simon Horman <horms@...ge.net.au>
Subject: Re: [RESEND] [PATCH v4] sh_eth: update OF PHY registeration

2014-02-26 11:47 GMT-08:00 Sergei Shtylyov <sergei.shtylyov@...entembedded.com>:
[snip]

>> +               pn = of_parse_phandle(np, "phy-handle", 0);
>> +               phydev = of_phy_connect(ndev, pn,
>> +                                       sh_eth_adjust_link, 0,
>
>
>    Hm, that 0 corresponds to 'flags' parameter which is not used. I wonder
> if that was intentional...

This is a left-over from when we needed to set phydev->dev_flags, but
this is no longer necessary although of_phy_connect() kept the
argument. Setting phydev->dev_flags should be done before calling
phy_start(), so far we only have a two users in-tree: tg3.c and some
mach-pxa code doing that.

>
>
>> +                                       mdp->phy_interface);
>> +
>> +               if (!phydev)
>> +                       phydev = ERR_PTR(-ENOENT);

Sounds like this could be moved to of_phy_connect(), although not
necessarily as part of this patchset, also, we would need to update
the callers, but this would be more consistent.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html