netdev - Re: [PATCH] net: tcp: use NET_INC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140226.152008.1482124169770558659.davem@davemloft.net>
Date:	Wed, 26 Feb 2014 15:20:08 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	hannes@...essinduktion.org, fw@...len.de, netdev@...r.kernel.org
Subject: Re: [PATCH] net: tcp: use NET_INC_STATS()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 25 Feb 2014 04:31:03 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> While LINUX_MIB_TCPSPURIOUS_RTX_HOSTQUEUES can only be incremented
> in tcp_transmit_skb() from softirq (incoming message or timer
> activation), it is better to use NET_INC_STATS() instead of
> NET_INC_STATS_BH() as tcp_transmit_skb() can be called from process
> context.
> 
> This will avoid copy/paste confusion when/if we want to add
> other SNMP counters in tcp_transmit_skb()
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html