netdev - Re: [PATCH net v2] sfc: check for NULL efx->ptp_data in efx_ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140226.152244.2248312700324231740.davem@davemloft.net>
Date:	Wed, 26 Feb 2014 15:22:44 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ecree@...arflare.com
Cc:	netdev@...r.kernel.org, sshah@...arflare.com, ben@...adent.org.uk
Subject: Re: [PATCH net v2] sfc: check for NULL efx->ptp_data in
 efx_ptp_event

From: Edward Cree <ecree@...arflare.com>
Date: Tue, 25 Feb 2014 13:17:59 +0000

> If we receive a PTP event from the NIC when we haven't set up PTP state
> in the driver, we attempt to read through a NULL pointer efx->ptp_data,
> triggering a panic.
> 
> Signed-off-by: Edward Cree <ecree@...arflare.com>
> ---
> v2: resent using alpine, because Thunderbird mangled v1
> 
> While this shouldn't happen with existing released firmware, future
> sfn7322f firmware is planned to enable PPS irrespective of whether
> timestamping (and thus PTP) is enabled.  We are considering workarounds,
> but this defensive patch seemed like a good idea anyway in case the
> firmware gets in a muddle.
> Also, in principle this shouldn't happen on 3.14+ kernels as the driver
> should always set up PTP state at probe time (though there might still
> be a race against the firmware sending its first PPS), however 3.12 and
> 3.13 both supported EF10 but not PTP-on-EF10 and thus they never set up
> the PTP state; hence this fix should also be backported to those series.

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html