netdev - Re: [PATCH net-next] ieee802154: fix new function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Feb 2014 12:43:50 +0100
From:	Phoebe Buckheister <phoebe.buckheister@...m.fraunhofer.de>
To:	Jean Sacren <sakiwit@...il.com>
Cc:	Alexander Smirnov <alex.bluesman.smirnov@...il.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	linux-zigbee-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ieee802154: fix new function declaration

On Tue, 25 Feb 2014 22:38:29 -0700
Jean Sacren <sakiwit@...il.com> wrote:

> The commit 8fad346f366a7 ("eee802154: add basic support for RF212 to
> at86rf230 driver") introduced the new function is_rf212() with some
> minor issues in declaration:
> 
> 1) Fix the function type by changing it to bool as the function
>    definition returns a boolean value. Additionally both callers of
>    is_rf212() are expected to return a boolean value.
> 
> 2) Fix the function specifier by deleting the inline keyword as the
>    compiler takes care of that.
> 
> Signed-off-by: Jean Sacren <sakiwit@...il.com>
> Cc: Phoebe Buckheister <phoebe.buckheister@...m.fraunhofer.de>

+1. My original intent was to have is_rf212 as a predicate like that,
but I slipped.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html