netdev - Re: [PATCH 01/14] brcmfmac: add delay before unregistering the network device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <530DDB91.3070807@broadcom.com>
Date:	Wed, 26 Feb 2014 13:18:25 +0100
From:	Arend van Spriel <arend@...adcom.com>
To:	Johannes Berg <johannes@...solutions.net>
CC:	"John W. Linville" <linville@...driver.com>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH 01/14] brcmfmac: add delay before unregistering the network
 device

On 02/26/2014 12:48 PM, Johannes Berg wrote:
> On Wed, 2014-02-26 at 12:34 +0100, Arend van Spriel wrote:
> 
>>> I'm not sure this isn't still possible? I don't know when DELLINK is
>>> sent.
>>
>> Given the behaviour I would say before the netdev notifier, which may be
>> considered wrong. It depends whether the notifier was intended for the
>> kind of thing that cfg80211 is doing, ie. send a netlink event to
>> user-space?
> 
> Well, I checked:
> 
>                 call_netdevice_notifiers(NETDEV_UNREGISTER, dev);
> 
>                 if (!dev->rtnl_link_ops ||
>                     dev->rtnl_link_state == RTNL_LINK_INITIALIZED)
>                         rtmsg_ifinfo(RTM_DELLINK, dev, ~0U, GFP_KERNEL);
> 
> so ... :)

Feeling sad :-( but thanks for checking. Clearly need to look into this
some more. John, can you please drop this one.

Gr. AvS
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html