netdev - Re: net/mlx4_en: Pad ethernet packets smaller than 17 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1393512255.26794.20.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 27 Feb 2014 06:44:15 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Amir Vadai <amirv@...lanox.com>
Cc:	David Laight <David.Laight@...LAB.COM>,
	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Eugenia Emantayev <eugenia@...lanox.com>
Subject: Re: net/mlx4_en: Pad ethernet packets smaller than 17 bytes

On Thu, 2014-02-27 at 16:02 +0200, Amir Vadai wrote:
>  
> Yes, skb will not be classified as inline-able if nr_frags != 1.
> See is_inline()

How often this inline stuff ever happens ?

It looks like the length of the frame needs to be shorter than 44 bytes,
right ?

Minimal length for TCP is 54 bytes.

I wonder why you tried to inline stuff that is probably never
seen in real workload.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html