netdev - Re: net/mlx4_en: Pad ethernet packets smaller than 17 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140227.153601.1100017228027738567.davem@davemloft.net>
Date:	Thu, 27 Feb 2014 15:36:01 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	amirv@...lanox.com
Cc:	eric.dumazet@...il.com, David.Laight@...LAB.COM,
	netdev@...r.kernel.org, yevgenyp@...lanox.com,
	ogerlitz@...lanox.com, eugenia@...lanox.com
Subject: Re: net/mlx4_en: Pad ethernet packets smaller than 17 bytes

From: Amir Vadai <amirv@...lanox.com>
Date: Thu, 27 Feb 2014 17:46:37 +0200

> On 27/02/14 06:44 -0800, Eric Dumazet wrote:
>> On Thu, 2014-02-27 at 16:02 +0200, Amir Vadai wrote:
>> >  
>> > Yes, skb will not be classified as inline-able if nr_frags != 1.
>> > See is_inline()
> 
> Maybe I wasn't accurate enough. inline-able skb must have:
> 1. skb->len < inline_thold 
> 2. nr_frags <= 1
> 
> Default value for inline_thold is 104 and it is a module parameter
> that can be changed.

BTW, the canonical way to deal with minimum length requirements is to
use skb_padto().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html