netdev - Re: [PATCH net-next v5 8/8] 6lowpan: handling 6lowpan fragmentation via inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140227211652.GA29339@omega>
Date:	Thu, 27 Feb 2014 22:16:54 +0100
From:	Alexander Aring <alex.aring@...il.com>
To:	David Miller <davem@...hat.com>
Cc:	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	linux-zigbee-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	martin.townsend@...lon.com
Subject: Re: [PATCH net-next v5 8/8] 6lowpan: handling 6lowpan fragmentation
 via inet_frag api

Hi David,

On Thu, Feb 27, 2014 at 03:56:39PM -0500, David Miller wrote:
> From: Alexander Aring <alex.aring@...il.com>
> Date: Thu, 27 Feb 2014 09:06:22 +0100
> 
> > +static int lowpan_frag_queue(struct lowpan_frag_queue *fq,
> > +			     struct sk_buff *skb, const u8 frag_type,
> > +			     const struct ieee802154_frag_info *frag_info)
> 
> The 'frag_info' argument is unused.  You always explicitly access
> mac_cb()->frag_info here.

You are absolutly right, sorry for that. I will remove this parameter
instead of using frag_info than mac_cb(skb)->frag_info... because I
compare with some other sk buffs like mac(next)->frag_info. This will be
more easier to read.

Thanks.

- Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html