netdev - Re: [PATCH] net: phy: Add support for SMSC/Microchip LAN9303 3-port switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcZd7mO6t4eAsn6HVNWFZpPopkBk2trjgSh+3rcWQPHw7g@mail.gmail.com>
Date:	Thu, 27 Feb 2014 14:21:49 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	David Miller <davem@...emloft.net>, Felix Fietkau <nbd@...nwrt.org>
Cc:	Stefan Roese <sr@...x.de>, netdev <netdev@...r.kernel.org>,
	r.meier@...mens.com, lukas.stockmann@...mens.com
Subject: Re: [PATCH] net: phy: Add support for SMSC/Microchip LAN9303 3-port switch

2014-02-27 14:02 GMT-08:00 David Miller <davem@...emloft.net>:
> From: Stefan Roese <sr@...x.de>
> Date: Thu, 27 Feb 2014 10:07:52 +0100
>
>> This driver exposes a sysfs interface to access the LAN9303 registers to
>> userspace. These sysfs files can be used to configure the switch.
>>
>> Signed-off-by: Stefan Roese <sr@...x.de>
>
> We have an abstraction for programming switch devices called DSA.
>
> Even if DSA doesn't fullfill your needs, doing adjustments using sysfs
> files in userland is going to be the worst user experience possible.

If you remember the discussion that started around the 'swconfig'
patches, DSA is not suitable for all types of switches, especially not
those which have no proprietary tagging support (which are about 80%
of the switches used in embedded systems). That discussion has kind of
stalled now, so we should probably bring it back...

>
> Every driver will export different things to tweak, each device will
> have different semantics and limitations for these settings, etc.
>
> Better is to come up with a real, types, interface for programming
> such devices and providing an implementation of that.

These are definitively the goals of the 'swconfig' patches that were
posted a while ago, to provide an unified programming API.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html