netdev - Re: How to best consolidate list of skbs (msdu) for receive?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1393540305.26794.47.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 27 Feb 2014 14:31:45 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ben Greear <greearb@...delatech.com>
Cc:	Florian Fainelli <f.fainelli@...il.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: How to best consolidate list of skbs (msdu) for receive?

On Thu, 2014-02-27 at 13:51 -0800, Ben Greear wrote:

> That said, the code below appears to work, even if it is
> not as efficient as it might be?
> 
> 			if (msdu_chaining) {
> 				struct sk_buff *next = msdu_head->next;
> 				struct sk_buff *to_free = next;
> 				int space;
> 				static int do_once = 1;
> 				msdu_head->next = NULL;
> 
> 				if (unlikely(do_once)) {
> 					ath10k_warn("htt rx msdu_chaining detected %d\n",
> 						    msdu_chaining);
> 					do_once = 0;
> 				}
> 
> 				while (next) {
> 					space = next->len - skb_tailroom(msdu_head);
> 
> 					if ((space > 0) &&
> 					    (pskb_expand_head(msdu_head, 0, space, GFP_ATOMIC) < 0)) {
> 						/* TODO:  bump some rx-oom error stat */
> 						goto outside_continue;
> 					}
> 					skb_copy_from_linear_data(next, skb_put(msdu_head, next->len),
> 								  next->len);
> 					next = next->next;
> 				}

Yep, this is very inefficient , you might copy data very often in
pskb_expand_head(), then in skb_copy_from_linear_data()

Also, if total length is big, you end up doing high order allocations,
since you generate a linear skb. This might fail under memory pressure.

What is the maximal skb->len of resulting skb ?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html