netdev - RE: [E1000-devel] [PATCH net-next] ixgbevf: fix skb->pkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F6FB0E698C9B3143BDF729DF2228664685D6D5BF@ORSMSX110.amr.corp.intel.com>
Date:	Thu, 27 Feb 2014 22:39:05 +0000
From:	"Skidmore, Donald C" <donald.c.skidmore@...el.com>
To:	David Miller <davem@...hat.com>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>
CC:	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Brown, Aaron F" <aaron.f.brown@...el.com>
Subject: RE: [E1000-devel] [PATCH net-next] ixgbevf: fix skb->pkt_type checks

> -----Original Message-----
> From: David Miller [mailto:davem@...hat.com]
> Sent: Thursday, February 27, 2014 1:08 PM
> To: f.fainelli@...il.com
> Cc: e1000-devel@...ts.sourceforge.net; netdev@...r.kernel.org;
> Brandeburg, Jesse
> Subject: Re: [E1000-devel] [PATCH net-next] ixgbevf: fix skb->pkt_type
> checks
> 
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Wed, 26 Feb 2014 14:44:00 -0800
> 
> > skb->pkt_type is not a bitmask, but contains only value at a time from
> > the range defined in include/uapi/linux/if_packet.h.
> >
> > Checking it like if it was a bitmask of values would also cause
> > PACKET_OTHERHOST, PACKET_LOOPBACK and PACKET_FASTROUTE to be
> matched
> > by this check since their lower 2 bits are also set, although that
> > does not fix a real bug due to how the checks are used, it is still potentially
> confusing.
> >
> > This bogus check was introduced in commit 815cccbf ("ixgbe: add
> > setlink, getlink support to ixgbe and ixgbevf").
> >
> > Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> 
> Intel folks, I assume you will pick this up?
> 

This patch looks like it fixes an obvious bug on our part.  I'm sure Aaron will get to it soon.

Thanks Florin for pointing this out,
-Don Skidmore <donald.c.skidmore@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html