netdev - Re: [PATCH 2/2] ethtool: allow for a smaller build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1393541570.14067.73.camel@deadeye.wl.decadent.org.uk>
Date:	Thu, 27 Feb 2014 22:52:50 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] ethtool: allow for a smaller build

On Wed, 2014-02-26 at 17:35 -0800, Florian Fainelli wrote:
> Introduce a new configure script option: --enable-small which will
> disable building the driver specific register dump objects, the savings
> are:
> 
> ~500 Kbytes on a x86_64 build
> ~337 Kbytes on a arm build

OK, I can see that will be useful in some environments.

[...]
> --- a/configure.ac
> +++ b/configure.ac
> @@ -30,5 +30,13 @@ dnl Checks for library functions.
>  AC_HEADER_STDC
>  AC_CHECK_FUNCS(socket strtol)
>  
> +dnl Check for options
> +AC_ARG_ENABLE(small,
> +	       [  --enable-small	  disable registers and EEPROM pretty dumps (disabled by default)],

That's a slightly confusing description.  It could be read as meaning
that the pretty dumps are disabled by default.

Maybe change the sense of this and call it --enable-pretty-dump, enabled
by default?

> +	       [if test x$enableval = xyes; then
> +			AC_DEFINE(SMALL, 1, [Define this to disable register and EEPROM pretty dumps.]) enable_small=yes
> +		fi])
> +AM_CONDITIONAL([SMALL], [test x$enable_small = xyes])
[...]

As this is defining a macro which is effectively global, please rename
it to a more specific name like ETHTOOL_SMALL (or reversing the sense,
ETHTOOL_ENABLE_PRETTY_DUMP).

Please also make the ethtool --version option report whether it's a
small build.

Ben.

-- 
Ben Hutchings
It is easier to change the specification to fit the program than vice versa.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)