netdev - Re: [PATCH net-next] consolidate duplicate code is skb_checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140227.181842.277867476845635582.davem@davemloft.net>
Date:	Thu, 27 Feb 2014 18:18:42 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	Paul.Durrant@...rix.com
Cc:	JBeulich@...e.com, edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] consolidate duplicate code is
 skb_checksum_setup() helpers

From: Paul Durrant <Paul.Durrant@...rix.com>
Date: Thu, 27 Feb 2014 12:39:01 +0000

> I don't know off the top of my head - I'd have to go look. My hunch
> is that TCP options are essentially independent of IP
> version. Anyway, the header is limited to 60 bytes max due to the 4
> bit width of the header length field so you may as well just use
> that.

Regardless, the MAX_IP_HDR_LEN macro that was being used in these
routines makes the intent clear, that the TCP options need to be
encompassed.

And this new consolidated code does not do that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html