netdev - Re: [PATCH net] ipv6: ipv6_find_hdr restore prev functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140227.182803.2159868180417685841.davem@davemloft.net>
Date:	Thu, 27 Feb 2014 18:28:03 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hans@...illstrom.com
Cc:	netdev@...r.kernel.org, ja@....bg, aatteka@...ira.com,
	kaber@...sh.net, ard@...egraafnet.nl, lvs-devel@...r.kernel.org
Subject: Re: [PATCH net] ipv6: ipv6_find_hdr restore prev functionality

From: Hans Schillstrom <hans@...illstrom.com>
Date: Thu, 27 Feb 2014 12:57:58 +0100

> The commit 9195bb8e381d81d5a315f911904cdf0cfcc919b8 ("ipv6: improve 
> ipv6_find_hdr() to skip empty routing headers") broke ipv6_find_hdr().
> 
> When a target is specified like IPPROTO_ICMPV6 ipv6_find_hdr()
> returns -ENOENT when it's found, not the header as expected.
> 
> A part of IPVS is broken and possible also nft_exthdr_eval().
> When target is -1 which it is most cases, it works.
> 
> This patch exits the do while loop if the specific header is found
> so the nexthdr could be returned as expected.
> 
> Reported-by: Art -kwaak- van Breemen <ard@...egraafnet.nl>
> Signed-off-by: Hans Schillstrom <hans@...illstrom.com>
> CC:Ansis Atteka <aatteka@...ira.com>

Looks good, applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html