netdev - Re: [PATCH V5 net-next 4/5] xen-netfront: Add support for multiple queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140228152250.GP16241@zion.uk.xensource.com>
Date:	Fri, 28 Feb 2014 15:22:50 +0000
From:	Wei Liu <wei.liu2@...rix.com>
To:	"Andrew J. Bennieston" <andrew.bennieston@...rix.com>
CC:	<xen-devel@...ts.xenproject.org>, <ian.campbell@...rix.com>,
	<wei.liu2@...rix.com>, <paul.durrant@...rix.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH V5 net-next 4/5] xen-netfront: Add support for multiple
 queues

On Mon, Feb 24, 2014 at 02:33:06PM +0000, Andrew J. Bennieston wrote:
> From: "Andrew J. Bennieston" <andrew.bennieston@...rix.com>
> 
> Build on the refactoring of the previous patch to implement multiple
> queues between xen-netfront and xen-netback.
> 
> Check XenStore for multi-queue support, and set up the rings and event
> channels accordingly.
> 
> Write ring references and event channels to XenStore in a queue
> hierarchy if appropriate, or flat when using only one queue.
> 
> Update the xennet_select_queue() function to choose the queue on which
> to transmit a packet based on the skb hash result.
> 
> Signed-off-by: Andrew J. Bennieston <andrew.bennieston@...rix.com>
> ---
>  drivers/net/xen-netfront.c |  178 ++++++++++++++++++++++++++++++++++----------
>  1 file changed, 140 insertions(+), 38 deletions(-)
> 
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 4f5a431..470d6ed 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -57,6 +57,12 @@
>  #include <xen/interface/memory.h>
>  #include <xen/interface/grant_table.h>
>  
> +/* Module parameters */
> +unsigned int xennet_max_queues;
> +module_param(xennet_max_queues, uint, 0644);
> +MODULE_PARM_DESC(xennet_max_queues,
> +		"Maximum number of queues per virtual interface");
> +

Maybe I'm nit-picking here. But I think exposing xennet_max_queues as
sysfs knob in frontend v.s. xenvif_max_queues in backend doesn't look
very good to me -- userspace tools would need to query different knobs
in frontend and backend. I think it makes sense to use a unified name in
both frontend and backend.

You can either use xenvif_max_queues as backend does or even just
max_queues for both frontend and backend.

Wei.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html