netdev - Re: [PATCH iproute2] iplink_bond_slave: show mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140228101411.5048a69d@nehalam.linuxnetplumber.net>
Date:	Fri, 28 Feb 2014 10:14:11 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Michal Kubecek <mkubecek@...e.cz>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] iplink_bond_slave: show mii_status only once

On Fri, 28 Feb 2014 14:58:15 +0100 (CET)
Michal Kubecek <mkubecek@...e.cz> wrote:

> With "ip -d link show", bonding slave mii status is displayed
> twice, once as a number and once as a name.
> 
> Fixes: 730d3f61 ("iplink: add support for bonding slave")
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
> ---
>  ip/iplink_bond_slave.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ip/iplink_bond_slave.c b/ip/iplink_bond_slave.c
> index bb4e1d6..8f3fc6c 100644
> --- a/ip/iplink_bond_slave.c
> +++ b/ip/iplink_bond_slave.c
> @@ -43,7 +43,6 @@ static void print_slave_mii_status(FILE *f, struct rtattr *tb)
>  {
>  	unsigned int status = rta_getattr_u8(tb);
>  
> -	fprintf(f, "mii_status %d ", status);
>  	if (status >= sizeof(slave_mii_status) / sizeof(slave_mii_status[0]))
>  		fprintf(f, "mii_status %d ", status);
>  	else

Applied
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html