[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20140228.171818.653889870218162486.davem@davemloft.net>
Date: Fri, 28 Feb 2014 17:18:18 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: ivecera@...hat.com
Cc: netdev@...r.kernel.org, rmody@...cade.com, jiri@...nulli.us,
fw@...len.de
Subject: Re: [PATCH net v3] bna: fix vlan tag stripping and implement its
toggling
From: Ivan Vecera <ivecera@...hat.com>
Date: Fri, 28 Feb 2014 14:14:03 +0100
> The recent commit "fe1624c bna: RX Filter Enhancements" disables
> VLAN tag stripping if the NIC is in promiscuous mode. This causes
> __vlan_hwaccel_put_tag() is called when the stripping is disabled.
> Because of this VLAN over bna does not work and causes BUGs in conjunction
> with openvswitch like this:
...
> The following patch makes the following changes so the driver:
> 1. Implements .ndo_set_features so an user can toggle VLAN tag stripping
> on/off
> 2. Does not disable VLAN tag stripping in promiscuous mode so the driver
> respect user's choice
> 3. Calls __vlan_hwaccel_put_tag() only when the stripping is enabled
>
> v2:
> - make bnad_set_features static (thanks Florian Westphal)
> - enable/disable VLAN stripping during open WRT hw_features
>
> v3:
> - enable/disable VLAN stripping during open WRT features and not hw_features
>
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
Ok, I'm fine with this fix for now, applied thanks Ivan.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists