netdev - Re: [PATCH net-next] ixgbevf: fix skb->pkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B73162EDE@ORSMSX101.amr.corp.intel.com>
Date:	Fri, 28 Feb 2014 23:26:15 +0000
From:	"Brown, Aaron F" <aaron.f.brown@...el.com>
To:	"f.fainelli@...il.com" <f.fainelli@...il.com>
CC:	"Duyck, Alexander H" <alexander.h.duyck@...el.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>
Subject: Re: [PATCH net-next] ixgbevf: fix skb->pkt_type checks

On Thu, 2014-02-27 at 14:58 -0800, Aaron Brown wrote:
> On Wed, 2014-02-26 at 14:44 -0800, Florian Fainelli wrote:
> > skb->pkt_type is not a bitmask, but contains only value at a time from
> > the range defined in include/uapi/linux/if_packet.h.
> > 
> > Checking it like if it was a bitmask of values would also cause
> > PACKET_OTHERHOST, PACKET_LOOPBACK and PACKET_FASTROUTE to be matched by this
> > check since their lower 2 bits are also set, although that does not fix a real
> > bug due to how the checks are used, it is still potentially confusing.
> > 
> > This bogus check was introduced in commit 815cccbf ("ixgbe: add setlink,
> > getlink support to ixgbe and ixgbevf").
> > 
> > Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> > ---
> >  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Thanks Florian, I have added this to our internal queue.

Unfortunately this introduces a compile error:
----------------------------------------------
/usr/src/kbuild_net-next_community/arch/x86/Makefile:133: CONFIG_X86_X32
enabled but no binutils support
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c: In function
‘ixgbevf_clean_rx_irq’:
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:521: error: ‘adapter’
undeclared (first use in this function)
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:521: error: (Each
undeclared identifier is reported only once
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:521: error: for each
function it appears in.)
make[5]: *** [drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [drivers/net/ethernet/intel/ixgbevf] Error 2
make[3]: *** [drivers/net/ethernet/intel] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [drivers/net/ethernet] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
~                                
----------------------------------------------
Are willing to fix up a v2?

Thanks,
Aaron