lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Feb 2014 16:52:29 +0800 From: Ding Tianhong <dingtianhong@...wei.com> To: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>, <kaber@...sh.net>, <julia.lawall@...6.fr> CC: <joe@...ches.com>, <davem@...emloft.net>, <netdev@...r.kernel.org> Subject: Re: [PATCH net-next 1/2] vlan: don't allow vlan device to move between network namespaces On 2014/2/28 16:12, Toshiaki Makita wrote: > (2014/02/28 16:50), Ding Tianhong wrote: >> Now the vlan device could move to another network namespace, but >> the read dev is sill in the old network namespace, it is unsafe >> and the vlan device could not work well, so don't allow to do it. > > Why is this a problem? > This looks like a useful feature to me. > > Thanks, > Toshiaki Makita > I think the vlan dev is a virtual device, if it does not with real dev together, I am not sure whether it is correct. Maybe I miss something, pls remind me. Thanks Ding >> >> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com> >> --- >> net/8021q/vlan_dev.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c >> index 566adbf..76d8fab 100644 >> --- a/net/8021q/vlan_dev.c >> +++ b/net/8021q/vlan_dev.c >> @@ -791,5 +791,8 @@ void vlan_setup(struct net_device *dev) >> dev->destructor = free_netdev; >> dev->ethtool_ops = &vlan_ethtool_ops; >> >> + /* don't allow vlan device to move between network namespaces */ >> + dev->features |= NETIF_F_NETNS_LOCAL; >> + >> memset(dev->broadcast, 0, ETH_ALEN); >> } >> > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists