netdev - Re: [PATCH net-next] bonding: send arp requests even if there's no route to them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1393585971.10280.5.camel@joe-AO722>
Date:	Fri, 28 Feb 2014 03:12:51 -0800
From:	Joe Perches <joe@...ches.com>
To:	Veaceslav Falico <vfalico@...hat.com>
Cc:	netdev@...r.kernel.org,
	François CACHEREUL <f.cachereul@...halink.fr>,
	Zhenjie Chen <zhchen@...hat.com>,
	Jay Vosburgh <fubar@...ibm.com>,
	Andy Gospodarek <andy@...yhouse.net>
Subject: Re: [PATCH net-next] bonding: send arp requests even if there's no
 route to them

On Fri, 2014-02-28 at 11:57 +0100, Veaceslav Falico wrote:
> Currently we're only sending arp requests if we have a route to the target
> (and, thus, can find out the source ip address).
> 
> There are some use cases, however, where we don't want/need to set an ip
> address (or set up a specific route) for bonding to use arp monitoring *for
> traffic generation*. We can easily send arp probes (arp requests with src
> ip == 0) to generate arp broadcast responses from the target ip and use
> them for determining if the target is up.
> 
> This, obviously, won't work with arp validation - because we don't have the
> ip address set and, thus, will filter out the responses. So in that case -
> print a warning.
[]
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
[]
> @@ -2155,8 +2155,13 @@ static void bond_arp_send_all(struct bonding *bond, struct slave *slave)
[]
> +			if (bond->params.arp_validate)
> +				pr_warn("%s: no route to arp_ip_target %pI4 and arp_validate is set\n",
> +					bond->dev->name, &targets[i]);

Maybe

			if (bond->params.arp_validate && net_ratelimit())


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html