netdev - Re: [PATCH net-next v2] ixgbevf: fix skb->pkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B73162FE8@ORSMSX101.amr.corp.intel.com>
Date:	Sat, 1 Mar 2014 00:12:05 +0000
From:	"Brown, Aaron F" <aaron.f.brown@...el.com>
To:	"f.fainelli@...il.com" <f.fainelli@...il.com>
CC:	"Duyck, Alexander H" <alexander.h.duyck@...el.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>
Subject: Re: [PATCH net-next v2] ixgbevf: fix skb->pkt_type checks

On Fri, 2014-02-28 at 15:46 -0800, Florian Fainelli wrote:
> skb->pkt_type is not a bitmask, but contains only value at a time from
> the range defined in include/uapi/linux/if_packet.h.
> 
> Checking it like if it was a bitmask of values would also cause
> PACKET_OTHERHOST, PACKET_LOOPBACK and PACKET_FASTROUTE to be matched by
> this check since their lower 2 bits are also set, although that does not
> fix a real bug, it is still potentially confusing.
> 
> This bogus check was introduced in commit 815cccbf ("ixgbe: add setlink,
> getlink support to ixgbe and ixgbevf").
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> Changes in v2:
> - properly resolve the rebase, fixes the build failure in v1

Thanks Florian, I have pulled this one into our internal queue (and yes
it compiles fine.)