netdev - Re: [PATCH 1/2] b44: add calls to phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6403851.S1rVbK2KGG@lenovo>
Date:	Sun, 02 Mar 2014 10:53:10 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Hauke Mehrtens <hauke@...ke-m.de>
Cc:	davem@...emloft.net, zambrano@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] b44: add calls to phy_{start,stop}

Le dimanche 2 mars 2014, 17:29:33 Hauke Mehrtens a écrit :
> When support for external phys was added to b44, the calls to start and
> stop the phy were missing in the mac driver. This adds the calls to
> phy_start() and phy_stop().
> 
> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

> ---
>  drivers/net/ethernet/broadcom/b44.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/b44.c
> b/drivers/net/ethernet/broadcom/b44.c index 1f7b5aa..e8046e1 100644
> --- a/drivers/net/ethernet/broadcom/b44.c
> +++ b/drivers/net/ethernet/broadcom/b44.c
> @@ -1484,6 +1484,10 @@ static int b44_open(struct net_device *dev)
>  	add_timer(&bp->timer);
> 
>  	b44_enable_ints(bp);
> +
> +	if (bp->flags & B44_FLAG_EXTERNAL_PHY)
> +		phy_start(bp->phydev);
> +
>  	netif_start_queue(dev);
>  out:
>  	return err;
> @@ -1646,6 +1650,9 @@ static int b44_close(struct net_device *dev)
> 
>  	netif_stop_queue(dev);
> 
> +	if (bp->flags & B44_FLAG_EXTERNAL_PHY)
> +		phy_stop(bp->phydev);
> +
>  	napi_disable(&bp->napi);
> 
>  	del_timer_sync(&bp->timer);

-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html