lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 02 Mar 2014 20:09:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	steffen.klassert@...unet.com
Cc:	netdev@...r.kernel.org, christophe.gouault@...nd.com
Subject: Re: [PATCH RFC 01/12] xfrm: Introduce xfrm_input_afinfo to access
 the the callbacks properly

From: Steffen Klassert <steffen.klassert@...unet.com>
Date: Fri, 28 Feb 2014 11:31:11 +0100

> +	int err = 0;
> +	if (unlikely(afinfo == NULL))
> +		return -EINVAL;

A newline between local variable declarations and code, please.

> +	int err = 0;
> +	if (unlikely(afinfo == NULL))
> +		return -EINVAL;

Likewise.

> +	struct xfrm_input_afinfo *afinfo;
> +	if (unlikely(family >= NPROTO))
> +		return NULL;

Likewise.

> +	int ret;
> +	struct xfrm_input_afinfo *afinfo = xfrm_input_get_afinfo(family);
> +	if (!afinfo)
> +		return -EAFNOSUPPORT;

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists