lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 03 Mar 2014 21:44:24 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Hariprasad Shenai <hariprasad@...lsio.com>, netdev@...r.kernel.org, linux-rdma@...r.kernel.org CC: davem@...emloft.net, roland@...estorage.com, kumaras@...lsio.com, dm@...lsio.com, swise@...ngridcomputing.com, leedom@...lsio.com, santosh@...lsio.com, nirranjan@...lsio.com Subject: Re: [PATCHv2 net-next 09/31] iw_cxgb4: Treat CPL_ERR_KEEPALV_NEG_ADVICE as negative advice. Hello. On 03/03/2014 09:40 AM, Hariprasad Shenai wrote: > From: Steve Wise <swise@...ngridcomputing.com> > Based on original work by Anand Priyadarshee <anandp@...lsio.com>. > Signed-off-by: Steve Wise <swise@...ngridcomputing.com> > --- > drivers/infiniband/hw/cxgb4/cm.c | 25 +++++++++++++------------ > drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 1 + > 2 files changed, 14 insertions(+), 12 deletions(-) > diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c > index 74a2250..9387f74 100644 > --- a/drivers/infiniband/hw/cxgb4/cm.c > +++ b/drivers/infiniband/hw/cxgb4/cm.c > @@ -1648,6 +1648,16 @@ static inline int act_open_has_tid(int status) > status != CPL_ERR_ARP_MISS; > } > > +/* > + * Returns whether a CPL status conveys negative advice. Could fix the comment style to comply with the networking coding standards while at it. > + */ > +static int is_neg_adv(unsigned int status) > +{ > + return status == CPL_ERR_RTX_NEG_ADVICE || > + status == CPL_ERR_PERSIST_NEG_ADVICE || > + status == CPL_ERR_KEEPALV_NEG_ADVICE; > +} > + > #define ACT_OPEN_RETRY_COUNT 2 > > static int import_ep(struct c4iw_ep *ep, int iptype, __u8 *peer_ip, [...] > @@ -2266,15 +2276,6 @@ static int peer_close(struct c4iw_dev *dev, struct sk_buff *skb) > return 0; > } > > -/* > - * Returns whether an ABORT_REQ_RSS message is a negative advice. > - */ > -static int is_neg_adv_abort(unsigned int status) > -{ > - return status == CPL_ERR_RTX_NEG_ADVICE || > - status == CPL_ERR_PERSIST_NEG_ADVICE; > -} > - > static int peer_abort(struct c4iw_dev *dev, struct sk_buff *skb) > { > struct cpl_abort_req_rss *req = cplhdr(skb); WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists