netdev - Re: [PATCH net-next] ieee802154: fix at86rf212_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 03 Mar 2014 15:40:48 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sakiwit@...il.com
Cc:	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	linux-zigbee-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	phoebe.buckheister@...m.fraunhofer.de
Subject: Re: [PATCH net-next] ieee802154: fix at86rf212_set_txpower() exit
 path

From: Jean Sacren <sakiwit@...il.com>
Date: Sat,  1 Mar 2014 15:54:36 -0700

> The commit 9b2777d6089bc ("ieee802154: add TX power control to
> wpan_phy") introduced the new function at86rf212_set_txpower() with
> the questionable check of the return of __at86rf230_write() in the
> exit path:
> 
> 1) Both at86rf212_set_txpower() and __at86rf230_write() have the
>    same return type.
> 
> 2) Whatever __at86rf230_write() returns becomes the return value of
>    at86rf212_set_txpower().
> 
> Thus, fix the exit path by getting rid of that check entirely.
> 
> Signed-off-by: Jean Sacren <sakiwit@...il.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html