netdev - Re: [PATCH net-next v2 1/4] ieee802154: add generic header handling routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 03 Mar 2014 16:38:32 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	phoebe.buckheister@...m.fraunhofer.de
Cc:	netdev@...r.kernel.org, linux-zigbee-devel@...ts.sourceforge.net
Subject: Re: [PATCH net-next v2 1/4] ieee802154: add generic header
 handling routines

From: Phoebe Buckheister <phoebe.buckheister@...m.fraunhofer.de>
Date: Mon,  3 Mar 2014 16:30:03 +0100

> +/* pushes hdr onto the skb. fields of hdr->fc that can be calculated from
> + * the contents of hdr will be, and the actual value of those bits in
> +* hdr->fc will be ignored. this includes the INTRA_PAN bit and the frame

Please fix this comment's third line, there should be a leading space.

> +static void ieee802154_haddr_copy_swap(u8 *dest, const u8 *src)
> +{
> +	int i;
> +	for (i = 0; i < IEEE802154_ADDR_LEN; i++)
> +		dest[IEEE802154_ADDR_LEN - i - 1] = src[i];

Add an empty line between local variable declarations and code.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html