[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 03 Mar 2014 16:44:17 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: vyasevic@...hat.com
Cc: netdev@...r.kernel.org, fw@...len.de, borntraeger@...ibm.com,
jasowang@...hat.com, mst@...hat.com
Subject: Re: [PATCH v2 net] macvlan: Add support for 'always_on' offload
features
From: Vlad Yasevich <vyasevic@...hat.com>
Date: Mon, 3 Mar 2014 15:33:53 -0500
> Macvlan currently inherits all of its features from the lower
> device. When lower device disables offload support, this causes
> macvlan to disable offload support as well. This causes
> performance regression when using macvlan/macvtap in bridge
> mode.
>
> It can be easily demonstrated by creating 2 namespaces using
> macvlan in bridge mode and running netperf between them:
>
> MIGRATED TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to 10.0.0.1 () port 0 AF_INET
> Recv Send Send
> Socket Socket Message Elapsed
> Size Size Size Time Throughput
> bytes bytes bytes secs. 10^6bits/sec
>
> 87380 16384 16384 20.00 1204.61
>
> To restore the performance, we add software offload features
> to the list of "always_on" features for macvlan. This way
> when a namespace or a guest using macvtap initially sends a
> packet, this packet will not be segmented at macvlan level.
> It will only be segmented when macvlan sends the packet
> to the lower device.
>
> MIGRATED TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to 10.0.0.1 () port 0 AF_INET
> Recv Send Send
> Socket Socket Message Elapsed
> Size Size Size Time Throughput
> bytes bytes bytes secs. 10^6bits/sec
>
> 87380 16384 16384 20.00 5507.35
>
> Fixes: 6acf54f1cf0a6747bac9fea26f34cfc5a9029523 (macvtap: Add support of packet capture on macvtap device.)
> Fixes: 797f87f83b60685ff8a13fa0572d2f10393c50d3 (macvlan: fix netdev feature propagation from lower device)
> CC: Florian Westphal <fw@...len.de>
> CC: Christian Borntraeger <borntraeger@...ibm.com>
> CC: Jason Wang <jasowang@...hat.com>
> CC: Michael S. Tsirkin <mst@...hat.com>
> Tested-by: Christian Borntraeger <borntraeger@...ibm.com>
> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
Applied, thanks Vlad.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists