netdev - Re: [PATCHv3 net-next 29/31] iw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531610CE.7020608@cogentembedded.com>
Date:	Tue, 04 Mar 2014 20:43:42 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Hariprasad Shenai <hariprasad@...lsio.com>, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org
CC:	davem@...emloft.net, roland@...estorage.com, kumaras@...lsio.com,
	dm@...lsio.com, swise@...ngridcomputing.com, leedom@...lsio.com,
	santosh@...lsio.com, nirranjan@...lsio.com
Subject: Re: [PATCHv3 net-next 29/31] iw_cxgb4: minor fixes

Hello.

On 03/04/2014 03:41 PM, Hariprasad Shenai wrote:

> From: Steve Wise <swise@...ngridcomputing.com>

> Added some missing debug stats.

> Use uninitialized_var().

> Initialize reserved fields in a FW work request.

    You should really split this patch.

> Signed-off-by: Steve Wise <swise@...ngridcomputing.com>
> ---
>   drivers/infiniband/hw/cxgb4/cq.c       | 2 +-
>   drivers/infiniband/hw/cxgb4/mem.c      | 6 +++++-
>   drivers/infiniband/hw/cxgb4/qp.c       | 2 ++
>   drivers/infiniband/hw/cxgb4/resource.c | 8 ++++++--
>   4 files changed, 14 insertions(+), 4 deletions(-)
[...]

> diff --git a/drivers/infiniband/hw/cxgb4/resource.c b/drivers/infiniband/hw/cxgb4/resource.c
> index cdef4d7..16982f2 100644
> --- a/drivers/infiniband/hw/cxgb4/resource.c
> +++ b/drivers/infiniband/hw/cxgb4/resource.c
[...]
> @@ -323,7 +327,7 @@ u32 c4iw_rqtpool_alloc(struct c4iw_rdev *rdev, int size)
>   	PDBG("%s addr 0x%x size %d\n", __func__, (u32)addr, size << 6);
>   	if (!addr)
>   		printk_ratelimited(KERN_WARNING MOD "%s: Out of RQT memory\n",
> -		       pci_name(rdev->lldi.pdev));
> +			pci_name(rdev->lldi.pdev));

    This is not indented enough anyway, the like should start under 
KERN_WARNING, according to the networking coding style. Moreover, this change 
is now undocumented in the changelog.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html