netdev - Re: [PATCH net-next 1/6] tipc: allow connection shutdown callback to be invoked in advance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 04 Mar 2014 13:47:21 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	erik.hugne@...csson.com
Cc:	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
	jon.maloy@...csson.com, maloy@...jonn.com, ying.xue@...driver.com,
	paul.gortmaker@...driver.com, richard.alpe@...csson.com
Subject: Re: [PATCH net-next 1/6] tipc: allow connection shutdown callback
 to be invoked in advance

From: <erik.hugne@...csson.com>
Date: Tue, 4 Mar 2014 09:05:38 +0100

> @@ -401,7 +401,7 @@ static void cfg_conn_msg_event(int conid, struct sockaddr_tipc *addr,
>  
>  		ret = tipc_conn_sendmsg(&cfgsrv, conid, addr, rep_buf->data,
>  					rep_buf->len);
> -		if (ret < 0)
> +		if (ret == -ENOMEM)
>  			pr_err("Sending cfg reply message failed, no memory\n");
>  
>  		kfree_skb(rep_buf);

Even -ENOMEM doesn't deserve a pr_err() log message.

The memory allocators in the kernel generate log messages on memory allocation
failure, when appropriate, with full stack backtraces.

Please just remove this test entirely, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html