netdev - TX timestamping for ICMP (sfc and core)?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrXpaD4i9V2Qv_0xfouGRb_y27-R6fOQ5v4Q97jNwgecFA@mail.gmail.com>
Date:	Tue, 4 Mar 2014 12:43:34 -0800
From:	Andy Lutomirski <luto@...capital.net>
To:	Network Development <netdev@...r.kernel.org>,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>
Subject: TX timestamping for ICMP (sfc and core)?

I'm trying to get tx timestamping working on ping sockets.  My program
works fine (with hardware TX timestamps) if I send my "pings" on the
PTP UDP ports.  I want to send real ICMP pings, though.

It looks like there are two problems:

 - Something in the core code seems to eat SKBTX_HW_STAMP on ping
sockets.  At least, this code in efx_hard_start_xmit triggers for
IPPROTO_UDP on PTP ports but not for IPPROTO_ICMP:

        if (unlikely(efx_xmit_with_hwtstamp(skb)))
                printk(KERN_DEBUG "sfc: trying to do a TX timestamp\n");

 - The sfc driver refuses to timestamp non-PTP packets.  There's a
check in efx_hard_start_xmit and another in ptp.c.  I suspect that the
hardware can support timestamping any outgoing packet, but I'm not
really sure.  (I'm using an SFN7322F.)

Thanks,
Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html