netdev - RE: [PATCH v3 net-next 1/2] ethtool: Support for configurable RSS hash key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Mar 2014 10:53:57 +0000
From:	Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH v3 net-next 1/2] ethtool: Support for configurable RSS
 hash key

> >   *	Returns a negative error code or zero.
> >   * @set_rxfh_indir: Set the contents of the RX flow hash indirection table.
> >   *	Will not be called if @get_rxfh_indir_size returns zero.
> > + * @set_rxfh: Set the contents of the RX flow hash indirection table and
> > + *	hash key.
> > + *	Will not be called if @get_rxfh_indir_size and @get_rxfh_key_size
> > + *	returns zero.
>  ...
> > +	if (!(dev->ethtool_ops->get_rxfh_indir_size ||
> > +	      dev->ethtool_ops->get_rxfh_key_size ||
> > +	      dev->ethtool_ops->get_rxfh))
> > +		return -EOPNOTSUPP;
> 
> This may be just my taste but I prefer it if all the operations have to be non-
> NULL to support the new feature.  The code is so much easier to validate that
> way.

The intention was to have zero changes to the existing drivers those support indirection table configuration.
> 
> Even if you have to make generic "ethtool_get_rxfh_indir_size_zero"
> etc. routines that implementations hook up if they don't support the particular
> aspect, I prefer that to "NULL means this".
> 
> Could you make this change and resubmit?
I can make the proposed changes. Shall I submit all the NIC drivers patches as part of this patchset?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html