netdev - Re: [PATCH net-next] sfc: Use ether_addr_copy and eth_broadcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1394039419.3271.75.camel@joe-AO722>
Date:	Wed, 05 Mar 2014 09:10:19 -0800
From:	Joe Perches <joe@...ches.com>
To:	Edward Cree <ecree@...arflare.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	sshah@...arflare.com
Subject: Re: [PATCH net-next] sfc: Use ether_addr_copy and eth_broadcast_addr

On Wed, 2014-03-05 at 11:48 +0000, Edward Cree wrote:
> On 04/03/14 20:36, David Miller wrote:
> >> diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
[]
> >> @@ -162,8 +162,8 @@ static int efx_ef10_get_mac_address(struct efx_nic *efx, u8 *mac_address)
[]
> >> -	memcpy(mac_address,
> >> -	       MCDI_PTR(outbuf, GET_MAC_ADDRESSES_OUT_MAC_ADDR_BASE), ETH_ALEN);
> >> +	ether_addr_copy(mac_address,
> >> +	       MCDI_PTR(outbuf, GET_MAC_ADDRESSES_OUT_MAC_ADDR_BASE));
> > This is not indented correctly, the original code was.
> Oops, yes.
> After fixing that, checkpatch also complains about a couple of long
> lines (mcdi.c:1207-8).  Am I right in thinking that it's being
> overzealous and is best ignored in this case?

Dunno if it's being overzealous, but anywhere overly
long variable names exist, (36+ chars here), wrapping to
80 columns is a bit limited.

Anyway, I wouldn't consider those long lines a problem.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html