netdev - Re: [PATCH] net: unix socket code abuses csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140305142809.64a71498@kryten>
Date:	Wed, 5 Mar 2014 14:28:09 +1100
From:	Anton Blanchard <anton@...ba.org>
To:	David Miller <davem@...emloft.net>
Cc:	edumazet@...gle.com, gustavold@...ux.vnet.ibm.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: unix socket code abuses csum_partial


Hi Dave,

> Alternatively you could just make unix_hash_fold() use csum_fold(),
> right?
> 
> static inline unsigned int unix_hash_fold(__wsum n)
> {
> 	unsigned int hash = (__force unsigned int) csum_fold(n);
> 
> 	hash ^= hash>>8;
> 	return hash&(UNIX_HASH_SIZE-1);
> }

Thanks, sounds good. Updated patch on the way.

Anton
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html