netdev - Re: [RFC 1/2] net: Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140305093312.GA27992@unicorn.suse.cz>
Date:	Wed, 5 Mar 2014 10:33:13 +0100
From:	Michal Kubecek <mkubecek@...e.cz>
To:	Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Dept-HSGLinuxNICDev@...gic.com
Subject: Re: [RFC 1/2] net: Add support to configure SR-IOV VF minimum and
 maximum Tx rate through ip tool.

On Wed, Mar 05, 2014 at 02:33:35AM -0500, Sucheta Chakraborty wrote:
> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index 16410b6..fce6437 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -398,7 +398,8 @@ enum {
>  	IFLA_VF_UNSPEC,
>  	IFLA_VF_MAC,		/* Hardware queue specific attributes */
>  	IFLA_VF_VLAN,
> -	IFLA_VF_TX_RATE,	/* TX Bandwidth Allocation */
> +	IFLA_VF_TX_RATE,	/* Max TX Bandwidth Allocation */
> +	IFLA_VF_RATE,		/* Min and Max TX Bandwidth Allocation */
>  	IFLA_VF_SPOOFCHK,	/* Spoof Checking on/off switch */
>  	IFLA_VF_LINK_STATE,	/* link state enable/disable/auto switch */
>  	__IFLA_VF_MAX,

This would change the values of IFLA_VF_SPOOFCHK and IFLA_VF_LINK_STATE,
making "old" (including current) iproute2 incompatible with future
kernels and vice versa.

                                                         Michal Kubecek

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html