netdev - Re: [PATCH] net-gre-gro: Fix a bug that breaks the forwarding path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140306163001.GA3092@order.stressinduktion.org>
Date:	Thu, 6 Mar 2014 17:30:01 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Joseph Gasparakis <joseph.gasparakis@...el.com>
Cc:	Or Gerlitz <or.gerlitz@...il.com>,
	Tom Herbert <therbert@...gle.com>,
	Jerry Chu <hkchu@...gle.com>,
	David Miller <davem@...emloft.net>,
	Pravin B Shelar <pshelar@...ira.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>
Subject: Re: [PATCH] net-gre-gro: Fix a bug that breaks the forwarding path

On Thu, Mar 06, 2014 at 08:42:32AM -0800, Joseph Gasparakis wrote:
> 
> 
> On Wed, 5 Mar 2014, Or Gerlitz wrote:
> 
> > On Wed, Mar 5, 2014 at 2:50 AM, Tom Herbert <therbert@...gle.com> wrote:
> > > I am concerned that we are overloading the skb->encpasulation
> > 
> > Guys, so to sum up yesterday's messages on this thread -- do folks
> > think we can come up with better/proper definition for the
> > skb->encapsulation bit, or we have to make this multiple bits, or we
> > have (hopefully not too non linear) dependancy on proper
> > definitions/usage of the skb->ip_summed field?
> > 
> > 
> > Or.
> >
> 
> From my perspective I do not see a gap with the mentioned fields, but I am 
> open if anyone has something to suggest.

I am still unsure if we want to deal with segmentation in nested tunnels. In
that case I fear we would need additional markers when to actual segment the
UDP packet and update the fragments.

This came up in commit 91a48a2e85a3b7 ("ipv4: ipv6: better estimate tunnel
header cut for correct ufo handling").

Greetings,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html