netdev - Re: Bug 71591 - Temporary address re-generated when it should not (public address about to expire)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140306164309.GB3092@order.stressinduktion.org>
Date:	Thu, 6 Mar 2014 17:43:09 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Heiner Kallweit <heiner.kallweit@....de>
Cc:	netdev@...r.kernel.org
Subject: Re: Bug 71591 - Temporary address re-generated when it should not (public address about to expire)

On Thu, Mar 06, 2014 at 05:38:21PM +0100, Heiner Kallweit wrote:
> Recently I faced the issue that a public address was about to expire and 
> 3s before expiry a new temporary address was generated which instantly 
> went into deprecated state.
> This didn't do any harm however it's wrong IMHO. Problem seems to be in 
> function ipv6_create_tempaddr in addrconf.c.
> A new temporary address is generated if this condition is met: 
> tmp_prefered_lft > regen_advance
> tmp_prefered_lft however is an offset from tstamp, not from now.
> This condition only checks that the new address is preferred until more 
> than regen_advance from tstamp,
> but it should check that the new address is preferred until more than 
> regen_advance from now.
> 
> I submitted this issue to kernel bugzilla -> 71591
> Hannes asked me to propose a patch, here it comes.

You would need to follow Documentation/SubmittingPatches and provide a proper
signed-off-by.

Basically if scripts/checkpatch.pl --strict doesn't complain on your patch any
more, then you're ready to submit.

Otherwise the patch looks good to me.

Thanks,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html