| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20140306.145126.497070034648321818.davem@davemloft.net> Date: Thu, 06 Mar 2014 14:51:26 -0500 (EST) From: David Miller <davem@...emloft.net> To: dingtianhong@...wei.com Cc: ben@...adent.org.uk, john.r.fastabend@...el.com, kaber@...sh.net, netdev@...r.kernel.org, f.fainelli@...il.com Subject: Re: [PATCH net-next] vlan: Fix lockdep warning when vlan dev handle notification From: Ding Tianhong <dingtianhong@...wei.com> Date: Thu, 6 Mar 2014 22:13:33 +0800 > When I open the LOCKDEP config and run these steps: > > modprobe 8021q > vconfig add eth2 20 > vconfig add eth2.20 30 > ifconfig eth2 xx.xx.xx.xx > > then the Call Trace happened: ... > The reason is that all of the vlan dev have the same class key for dev_lock_list, > if we up or down the real dev, the notification will change the state for every > vlan dev in the vlan group, then the vlan dev will hold netif_addr_lock and the > real dev also hold its own netif_addr_lock together, so the warning happened. > > The best way to fix the problem is add a new class key for the vlan dev if its > real dev is a vlan dev too. > > Signed-off-by: Ding Tianhong <dingtianhong@...wei.com> So what happens when one does: vconfig add eth2 20 vconfig add eth2.20 30 vconfig add eth2.30 40 ifconfig eth2 xx.xx.xx.xx -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists